Skip to content
This repository has been archived by the owner. It is now read-only.

8279204: [BACKOUT] JDK-8278413: C2 crash when allocating array of size too large #69

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 23, 2021

Summary: This reverts commit deaf75a.

Roland is on vacation now, so we would not get the fix any time soon. Meanwhile, there are lots of test failures and GHA uncleanliness due to this patch.

Additional testing:

  • Test failures from recorded bugs are gone
  • Linux x86_64 fastdebug tier1
  • Linux x86_64 fastdebug tier2
  • Linux x86_64 fastdebug tier3
  • GHA are clean

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279204: [BACKOUT] JDK-8278413: C2 crash when allocating array of size too large

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/69/head:pull/69
$ git checkout pull/69

Update a local copy of the PR:
$ git checkout pull/69
$ git pull https://git.openjdk.java.net/jdk18 pull/69/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 69

View PR using the GUI difftool:
$ git pr show -t 69

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/69.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 23, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Dec 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 23, 2021

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

That seems reasonable. Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279204: [BACKOUT] JDK-8278413: C2 crash when allocating array of size too large

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 730f670: 8268297: jdk/jfr/api/consumer/streaming/TestLatestEvent.java times out
  • 9d5ae2e: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 04ee921: 8278967: rmiregistry fails to start because SecurityManager is disabled
  • 2be3e7e: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d
  • dfb15c3: 8274315: JFR: One closed state per file or stream
  • e49d4a9: 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters
  • 713fbeb: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
  • 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
  • 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
  • 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction
  • ... and 4 more: https://git.openjdk.java.net/jdk18/compare/db3d6d772411c4e7bc81d6411abb139462e1581f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 23, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 23, 2021

That seems reasonable. Looks good!

Thanks! Should I wait for 24 hours for this patch, or we consider clean backouts trivial?

Copy link

@vnkozlov vnkozlov left a comment

No need to wait. Approved.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 23, 2021

Thanks.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2021

Going to push as commit 04ad668.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 730f670: 8268297: jdk/jfr/api/consumer/streaming/TestLatestEvent.java times out
  • 9d5ae2e: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 04ee921: 8278967: rmiregistry fails to start because SecurityManager is disabled
  • 2be3e7e: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d
  • dfb15c3: 8274315: JFR: One closed state per file or stream
  • e49d4a9: 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters
  • 713fbeb: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
  • 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
  • 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
  • 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction
  • ... and 4 more: https://git.openjdk.java.net/jdk18/compare/db3d6d772411c4e7bc81d6411abb139462e1581f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 23, 2021
@openjdk openjdk bot closed this Dec 23, 2021
@openjdk openjdk bot removed ready rfr labels Dec 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2021

@shipilev Pushed as commit 04ad668.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the backout-JDK-8278413 branch Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler integrated
3 participants