Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8279379: GHA: Print tests that are in error #75

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 3, 2022

Current GHA workflow only prints newfailures.txt when tests fail. But the tests can also "ERROR" out. In which case, we want to print other_errors.txt as well. In current mainline GHA, we have a x86_32 langtools_tier1 failure like this:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
>> jtreg:test/langtools:tier1                         4282  4281     0     1 <<
==============================
TEST FAILURE

# newfailures.txt
<empty>

# other_errors.txt
jdk/javadoc/doclet/testLinkPlatform/TestLinkPlatform.java

I would like to get it in JDK 18 as well, to make GHA better during stabilization.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.java.net/jdk18 pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/75.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2022
@openjdk
Copy link

openjdk bot commented Jan 3, 2022

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.java.net label Jan 3, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 3, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279379: GHA: Print tests that are in error

Reviewed-by: erikj, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2022
@shipilev
Copy link
Member Author

shipilev commented Jan 4, 2022

Thanks for reviews, folks!

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2022

Going to push as commit 06f3713.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e7244c1: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2022
@openjdk openjdk bot closed this Jan 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2022
@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@shipilev Pushed as commit 06f3713.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build build-dev@openjdk.java.net integrated Pull request has been integrated
3 participants