8275830: C2: Receiver downcast is missing when inlining through method handle linkers

[iwanowww]

JDK-8268405 introduced receiver downcasts when inlining through virtual calls
when CHA reveals a unique target method under an abstract or default method.
But it handled only cases when invocation is performed using
invokevirtual/invokeinterface bytecodes and completely omitted invokedynamic and
MethodHandles cases.

The fix covers missing cases by checking whether invocation happens through
corresponding method handle linkers (MethodHandle.linkToVirtual/MethodHandle.linkToInterface).

Testing: hs-tier1 - hs-tier4

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275830: C2: Receiver downcast is missing when inlining through method handle linkers

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.java.net/jdk18 pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/77.diff

[bridgekeeper]

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iwanowww
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (957abf52)
• 00: Full (a10a1201)

[vnkozlov]

It is time to update Copyright year to 2022 in changed files.

[vnkozlov]

I think you also need to check that C2 is enabled (could be JVMCI).

[iwanowww]

Until JVMCI/Graal is migrated to vtable-based CHA, the tests are run only with C1/C2:

@requires !vm.graal.enabled & vm.opt.final.UseVtableBasedCHA == true

[iwanowww]

It is time to update Copyright year to 2022 in changed files.

Fixed.

[openjdk]

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275830: C2: Receiver downcast is missing when inlining through method handle linkers

Reviewed-by: kvn, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

I missed that tests already have this @require.

Good.

[iwanowww]

Thanks for the reviews, Vladimir and Dean.

/integrate

[openjdk]

Going to push as commit 95a3010.
Since your change was applied there have been 3 commits pushed to the master branch:

• 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
• 06f3713: 8279379: GHA: Print tests that are in error
• e7244c1: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638

Your commit was automatically rebased without conflicts.

[openjdk]

@iwanowww Pushed as commit 95a3010.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.