-
Notifications
You must be signed in to change notification settings - Fork 68
JDK-8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated #8
Conversation
… fails after the manpage was updated
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - so the previously missing options are now documented.
Looks good.
Thanks for the quick fix.
David
/integrate |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Going to push as commit 3df8dc4. |
@jonathan-gibbons Pushed as commit 3df8dc4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a fix to update this test to match the latest man page
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/8/head:pull/8
$ git checkout pull/8
Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jdk18 pull/8/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8
View PR using the GUI difftool:
$ git pr show -t 8
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/8.diff