Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk18 Public archive

8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 #83

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jan 5, 2022

A couple of trivial ProblemListings:

JDK-8279529 ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
JDK-8279532 ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
  • JDK-8279532: ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jdk18 pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/83.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs
/label add security

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8279529
/issue JDK-8279532

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.java.net label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk openjdk bot added the security security-dev@openjdk.java.net label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@dcubed-ojdk
The security label was successfully added.

@openjdk openjdk bot changed the title Jdk 8279529 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review January 5, 2022 17:29
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8279532: ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

Copy link
Member

@jnimeh jnimeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
8279532: ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java

Reviewed-by: jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2022
@AlanBateman
Copy link
Contributor

/label add nio
/label remove core-libs

@AlanBateman
Copy link
Contributor

This looks okay although I think we're working around a macOS or configuration issue rather than a JDK or test issue.

@openjdk openjdk bot added the nio nio-dev@openjdk.java.net label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@AlanBateman
The nio label was successfully added.

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.java.net label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@AlanBateman
The core-libs label was successfully removed.

@dcubed-ojdk
Copy link
Member Author

@jnimeh - Thanks for the review.

@AlanBateman - I presume you are talking about
java/nio/channels/DatagramChannel/ManySourcesAndTargets.java.
It could be a macosx-aarch64 config issue and if we can get to the
bottom of that issue, then we can re-enable the test. For now, with
the JDK18 clock ticking down, I'd like to reduce the noise in the CI.

Did you plan on adding your reviewer approval here?

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit 564c8c6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 590fa9d: 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2022
@openjdk openjdk bot closed this Jan 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@dcubed-ojdk Pushed as commit 564c8c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8279529 branch January 5, 2022 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.java.net integrated Pull request has been integrated nio nio-dev@openjdk.java.net security security-dev@openjdk.java.net
Development

Successfully merging this pull request may close these issues.

3 participants