-
Notifications
You must be signed in to change notification settings - Fork 66
8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 #83
Conversation
…Targets.java on macosx-aarch64
/label add hotspot-runtime |
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
/issue JDK-8279529 |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
@dcubed-ojdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/label add nio |
This looks okay although I think we're working around a macOS or configuration issue rather than a JDK or test issue. |
@AlanBateman |
@AlanBateman |
@jnimeh - Thanks for the review. @AlanBateman - I presume you are talking about Did you plan on adding your reviewer approval here? |
/integrate |
@dcubed-ojdk Pushed as commit 564c8c6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A couple of trivial ProblemListings:
JDK-8279529 ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
JDK-8279532 ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/83/head:pull/83
$ git checkout pull/83
Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jdk18 pull/83/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 83
View PR using the GUI difftool:
$ git pr show -t 83
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/83.diff