8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4

[fmatte1]

8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/89/head:pull/89
$ git checkout pull/89

Update a local copy of the PR:
$ git checkout pull/89
$ git pull https://git.openjdk.java.net/jdk18 pull/89/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 89

View PR using the GUI difftool:
$ git pr show -t 89

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/89.diff

[bridgekeeper]

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fmatte1 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (161a730e)

[chhagedorn]

Looks good!

[openjdk]

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 06b4d49: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output
• 8f969a1: 8278930: javac tries to compile a file twice via PackageElement.getEnclosedElements
• 642ab34: 8278373: JavacTrees.searchMethod finds incorrect match

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[fmatte1]

Thanks, Christian for the review...

[TobiHartmann]

Looks good to me too.

[fmatte1]

Looks good to me too.

Thanks, Tobias for the review...

[fmatte1]

This was my findings before arriving at the suggestion,
I just reduced test case to make it bit quick, below are the results

-           for (int i = 0; i < 10000; ++i) {
+            for (int i = 0; i < 1000; ++i) {
                 instance.mainTest(args);
             }

[fmatte1]

Interpreter -Xint - 1843.357 seconds
C1 with TieredStopAtLevel=3 - 1636.454 seconds
C2 (default) - 1.862 seconds

For me it looks like it is not an issue with the C1 or interpreter.

The test case is designed to execute only on C2

We may need to fix the testcase with @requires vm.compiler2.enabled

[fmatte1]

/integrate

[openjdk]

@fmatte1
Your change (at version 161a730) is now ready to be sponsored by a Committer.

[chhagedorn]

/sponsor

[openjdk]

Going to push as commit 928e347.
Since your change was applied there have been 4 commits pushed to the master branch:

• 354c904: 8273452: DocTrees.getDocCommentTree should be specified as idempotent
• 06b4d49: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output
• 8f969a1: 8278930: javac tries to compile a file twice via PackageElement.getEnclosedElements
• 642ab34: 8278373: JavacTrees.searchMethod finds incorrect match

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn @fmatte1 Pushed as commit 928e347.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.