Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 #91

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 10, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.java.net/jdk18 pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/91.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9bdf6eb7b2412ecff523015f1430dfb6a0e4dd09 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279385: [test]  Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344

Reviewed-by: mullan, xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • 2531c33: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • ef08e2c: 8280592: Small javadoc tweaks to foreign API
  • ead9fec: 8280441: Missing "classpath exception" in several files from jdk.httpserver
  • 7d2ef9d: 8279179: Update nroff pages in JDK 18 before RC
  • 03680be: 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl
  • be0538d: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • f5de6fa: 8272058: 25 Null pointer dereference defect groups in 4 files
  • 28e02fa: 8280234: AArch64 "core" variant does not build after JDK-8270947
  • f37bfea: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 69cfa9c: 8273383: vmTestbase/vm/gc/containers/Combination05/TestDescription.java crashes verifying length of DCQS
  • ... and 51 more: https://git.openjdk.java.net/jdk18/compare/928e34773694dda5373027848a3363887bcaf4f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@MBaesken The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.java.net label Jan 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2022

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Feb 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 4, 2022

Going to push as commit 01f93dd.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 2531c33: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • ef08e2c: 8280592: Small javadoc tweaks to foreign API
  • ead9fec: 8280441: Missing "classpath exception" in several files from jdk.httpserver
  • 7d2ef9d: 8279179: Update nroff pages in JDK 18 before RC
  • 03680be: 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl
  • be0538d: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • f5de6fa: 8272058: 25 Null pointer dereference defect groups in 4 files
  • 28e02fa: 8280234: AArch64 "core" variant does not build after JDK-8270947
  • f37bfea: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 69cfa9c: 8273383: vmTestbase/vm/gc/containers/Combination05/TestDescription.java crashes verifying length of DCQS
  • ... and 51 more: https://git.openjdk.java.net/jdk18/compare/928e34773694dda5373027848a3363887bcaf4f4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2022
@openjdk openjdk bot closed this Feb 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2022
@openjdk
Copy link

openjdk bot commented Feb 4, 2022

@MBaesken Pushed as commit 01f93dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated security security-dev@openjdk.java.net
3 participants