Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8284920: Incorrect Token type causes XPath expression to return incorrect results #103

Closed
wants to merge 1 commit into from

Conversation

raviniitw2012
Copy link

@raviniitw2012 raviniitw2012 commented Apr 21, 2022

Clean backport of openjdk/jdk@81a8e2f to jdk18u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284920: Incorrect Token type causes XPath expression to return incorrect results

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/103/head:pull/103
$ git checkout pull/103

Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.java.net/jdk18u pull/103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 103

View PR using the GUI difftool:
$ git pr show -t 103

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/103.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2022

👋 Welcome back rreddy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 81a8e2f8b32ad27aed45c4f6966e8d9ecf8b0fc9 8284920: Incorrect Token type causes XPath expression to return incorrect results Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@raviniitw2012 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284920: Incorrect Token type causes XPath expression to return incorrect results

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c0d3d5e: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2022

Webrevs

@coffeys
Copy link
Contributor

coffeys commented Apr 21, 2022

/sponsor

@raviniitw2012
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@coffeys The change author (@raviniitw2012) must issue an integrate command before the integration can be sponsored.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@raviniitw2012
Your change (at version 54ef140) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Apr 21, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 21, 2022

Going to push as commit 07f4a0f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c0d3d5e: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 21, 2022
@openjdk openjdk bot closed this Apr 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@coffeys @raviniitw2012 Pushed as commit 07f4a0f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
3 participants