Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c #104

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 21, 2022

A clean, low risk backport that fixes a memory leak.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/104/head:pull/104
$ git checkout pull/104

Update a local copy of the PR:
$ git checkout pull/104
$ git pull https://git.openjdk.java.net/jdk18u pull/104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 104

View PR using the GUI difftool:
$ git pr show -t 104

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/104.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 36b3bbc53de074647ce04de890dc99bd5a2373e8 8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 07f4a0f: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • c0d3d5e: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 21, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

Going to push as commit 2b91865.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 313b033: 8285445: cannot open file "NUL:"
  • 07f4a0f: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • c0d3d5e: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2022
@openjdk openjdk bot closed this Apr 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@zhengyu123 Pushed as commit 2b91865.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant