Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8280910: Update openjdk project in jcheck to "jdk-updates" for jdk18u #11

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 29, 2022

The openjdk project in jcheck should be changed to "jdk-updates" for jdk18u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280910: Update openjdk project in jcheck to "jdk-updates" for jdk18u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.java.net/jdk18u pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/11.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review January 29, 2022 02:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280910: Update openjdk project in jcheck to "jdk-updates" for jdk18u

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 31, 2022
@mrserb
Copy link
Member Author

mrserb commented Feb 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

Going to push as commit e32fb7f.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 74e1fdb: Merge
  • ef08e2c: 8280592: Small javadoc tweaks to foreign API
  • 5b8f9ff: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • 86956ee: 8279445: Update JMH devkit to 1.34

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2022
@openjdk openjdk bot closed this Feb 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@mrserb Pushed as commit e32fb7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the type branch February 2, 2022 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants