Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler #111

Closed
wants to merge 2 commits into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 26, 2022

A clean and low risk backport to fix a memory leak.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/111/head:pull/111
$ git checkout pull/111

Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.java.net/jdk18u pull/111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 111

View PR using the GUI difftool:
$ git pr show -t 111

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/111.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b55c32f5fe452e2b4e6f912a7d27f979e68ba67e 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2022

Going to push as commit 17e28d9.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f142228: 8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id()
  • 2447d2f: 8282170: JVMTI SetBreakpoint metaspace allocation test
  • 191f045: 8284549: JFR: FieldTable leaks FieldInfoTable member
  • 6cc0a75: 8284620: CodeBuffer may leak _overflow_arena

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2022
@openjdk openjdk bot closed this May 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@zhengyu123 Pushed as commit 17e28d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant