-
Notifications
You must be signed in to change notification settings - Fork 52
8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id() #116
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
vnkozlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Got the push approval. |
|
Going to push as commit f142228.
Your commit was automatically rebased without conflicts. |
Unclean backport to fix Blackhole behavior. The test does not work until we add another
IRNodeconstant. Otherwise the test passes with the fix, and fails without it.Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/116/head:pull/116$ git checkout pull/116Update a local copy of the PR:
$ git checkout pull/116$ git pull https://git.openjdk.java.net/jdk18u pull/116/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 116View PR using the GUI difftool:
$ git pr show -t 116Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/116.diff