Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282170: JVMTI SetBreakpoint metaspace allocation test #117

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented May 2, 2022

Clean backport to improve testing.

Additional testing:

  • Linux x86_64 fastdebug, affected test passes
  • Linux x86_64 release, affected test passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282170: JVMTI SetBreakpoint metaspace allocation test

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/117/head:pull/117
$ git checkout pull/117

Update a local copy of the PR:
$ git checkout pull/117
$ git pull https://git.openjdk.java.net/jdk18u pull/117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 117

View PR using the GUI difftool:
$ git pr show -t 117

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/117.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b91bbba82e871edaf133343415e254972c6ddc7 8282170: JVMTI SetBreakpoint metaspace allocation test May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 2, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282170: JVMTI SetBreakpoint metaspace allocation test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels May 2, 2022
@mlbridge
Copy link

mlbridge bot commented May 2, 2022

Webrevs

@shipilev
Copy link
Contributor Author

shipilev commented May 4, 2022

Got the push approval.
/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2022

Going to push as commit 2447d2f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 191f045: 8284549: JFR: FieldTable leaks FieldInfoTable member
  • 6cc0a75: 8284620: CodeBuffer may leak _overflow_arena

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 4, 2022
@openjdk openjdk bot closed this May 4, 2022
@openjdk openjdk bot removed ready rfr labels May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@shipilev Pushed as commit 2447d2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8282170-jvmti-metaspace-alloctest branch Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant