8284848: C2: Compiler blackhole arguments should be treated as globally escaping

[shipilev]

Unclean backport to improve Blackhole - EA interactions. The backport is not clean, because IRNode needs missing constants, and set_escape_state does not accept third argument (description) in 18u.

Additional testing:

• compiler/c2/irTests/blackhole fail without the patch, pass with it
• compiler/blackhole continue to pass

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8284848: C2: Compiler blackhole arguments should be treated as globally escaping

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 4d8669a4
• @brandingfuture (no known github.com user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/118/head:pull/118
$ git checkout pull/118

Update a local copy of the PR:
$ git checkout pull/118
$ git pull https://git.openjdk.java.net/jdk18u pull/118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 118

View PR using the GUI difftool:
$ git pr show -t 118

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/118.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (b58ac060)
• 00: Full (4d8669a4)

[vnkozlov]

Good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284848: C2: Compiler blackhole arguments should be treated as globally escaping

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 431e502: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297
• 2c01f3a: Merge
• 22a15d6: 8285445: cannot open file "NUL:"
• 1579390: 8284920: Incorrect Token type causes XPath expression to return incorrect results
• e47ee85: 8283350: (tz) Update Timezone Data to 2022a
• 482a4a9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
• 374d955: 8285454: Update the JBS version for respin of April CPU22_04
• 5879966: 8285391: Update the release version for respin April CPU22_04 for release jdk18.0.1.1
• 2725913: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
• 8aae185: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
• ... and 2 more: https://git.openjdk.java.net/jdk18u/compare/f142228202c2050dbed6805552c6c3675a712dd6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Got the push approval.

/integrate

[shipilev]

Got the push approval.

/integrate

[openjdk]

Going to push as commit 15776b5.
Since your change was applied there have been 12 commits pushed to the master branch:

• 431e502: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297
• 2c01f3a: Merge
• 22a15d6: 8285445: cannot open file "NUL:"
• 1579390: 8284920: Incorrect Token type causes XPath expression to return incorrect results
• e47ee85: 8283350: (tz) Update Timezone Data to 2022a
• 482a4a9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
• 374d955: 8285454: Update the JBS version for respin of April CPU22_04
• 5879966: 8285391: Update the release version for respin April CPU22_04 for release jdk18.0.1.1
• 2725913: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
• 8aae185: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
• ... and 2 more: https://git.openjdk.java.net/jdk18u/compare/f142228202c2050dbed6805552c6c3675a712dd6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 15776b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@shipilev The command integrate can only be used in open pull requests.