Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297 #120

Closed

Conversation

smita-kamath
Copy link

@smita-kamath smita-kamath commented May 3, 2022

Hi,

This is a backport of JDK-8283022. The patch applies cleanly to 18u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/120/head:pull/120
$ git checkout pull/120

Update a local copy of the PR:
$ git checkout pull/120
$ git pull https://git.openjdk.java.net/jdk18u pull/120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 120

View PR using the GUI difftool:
$ git pr show -t 120

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/120.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 3, 2022

👋 Welcome back svkamath! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3416bfa2560e240b5e602f10e98e8a06c96852df 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297 May 3, 2022
@openjdk
Copy link

openjdk bot commented May 3, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 3, 2022

@smita-kamath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 2c01f3a: Merge
  • 22a15d6: 8285445: cannot open file "NUL:"
  • 1579390: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • e47ee85: 8283350: (tz) Update Timezone Data to 2022a
  • 482a4a9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
  • 374d955: 8285454: Update the JBS version for respin of April CPU22_04
  • 5879966: 8285391: Update the release version for respin April CPU22_04 for release jdk18.0.1.1
  • 2725913: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
  • 8aae185: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
  • 0a14182: 8285686: Upgrade to FreeType 2.12.0
  • ... and 5 more: https://git.openjdk.java.net/jdk18u/compare/96f0e65c9dd2c6edf57f3f1d6c51e1eee45bc1ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 3, 2022
@mlbridge
Copy link

mlbridge bot commented May 3, 2022

Webrevs

@smita-kamath
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@smita-kamath
Your change (at version f11ae34) is now ready to be sponsored by a Committer.

@dwhite-intel
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented May 5, 2022

Going to push as commit 431e502.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 2c01f3a: Merge
  • 22a15d6: 8285445: cannot open file "NUL:"
  • 1579390: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • e47ee85: 8283350: (tz) Update Timezone Data to 2022a
  • 482a4a9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
  • 374d955: 8285454: Update the JBS version for respin of April CPU22_04
  • 5879966: 8285391: Update the release version for respin April CPU22_04 for release jdk18.0.1.1
  • 2725913: 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo
  • 8aae185: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
  • 0a14182: 8285686: Upgrade to FreeType 2.12.0
  • ... and 5 more: https://git.openjdk.java.net/jdk18u/compare/96f0e65c9dd2c6edf57f3f1d6c51e1eee45bc1ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2022
@openjdk openjdk bot closed this May 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@dwhite-intel @smita-kamath Pushed as commit 431e502.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants