Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8285956: (fs) Excessive default poll interval in PollingWatchService #121

Closed
wants to merge 1 commit into from

Conversation

backwaterred
Copy link
Contributor

@backwaterred backwaterred commented May 5, 2022

This PR backports changes that reduce the wait time for a user of the WatchService API on AIX and BSD.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285956: (fs) Excessive default poll interval in PollingWatchService

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/121/head:pull/121
$ git checkout pull/121

Update a local copy of the PR:
$ git checkout pull/121
$ git pull https://git.openjdk.java.net/jdk18u pull/121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 121

View PR using the GUI difftool:
$ git pr show -t 121

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/121.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2022

👋 Welcome back backwaterred! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1bb4de2e2868a539846ec48dd43fd623c2ba69a5 8285956: (fs) Excessive default poll interval in PollingWatchService May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 5, 2022
@mlbridge
Copy link

mlbridge bot commented May 5, 2022

Webrevs

@openjdk openjdk bot added the clean label May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285956: (fs) Excessive default poll interval in PollingWatchService

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 431e502: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022
@backwaterred
Copy link
Contributor Author

Pre-test failures were not present before, and are now failing for reasons which appear unrelated to this PR.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@backwaterred
Your change (at version 06a911f) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 25, 2022

Going to push as commit ddf8877.
Since your change was applied there have been 12 commits pushed to the master branch:

  • c575496: 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk
  • b9e100c: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • 642208c: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • 2e9dda4: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 3d54587: 8286283: assert(func2 == 0 && func3 == 0) failed: not unary
  • aac6bd5: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 9d0d8ea: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • b5bf90d: 8284992: Fix misleading Vector API doc for LSHR operator
  • 0b9bee7: 8286198: [linux] Fix process-memory information
  • 3b7473c: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
  • ... and 2 more: https://git.openjdk.java.net/jdk18u/compare/2c01f3a5e3f079d8f5eb417415034759cd9a8b4b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2022
@openjdk openjdk bot closed this May 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 25, 2022
@openjdk
Copy link

openjdk bot commented May 25, 2022

@RealCLanger @backwaterred Pushed as commit ddf8877.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants