Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8286601: Mac Aarch: Excessive warnings to be ignored for build jdk #131

Closed

Conversation

adamfarley
Copy link

@adamfarley adamfarley commented May 13, 2022

Hi all,

This pull request contains a backport of commit 40f43c6b from the openjdk/jdk repository.

The commit being backported was authored by Adam Farley on 12 May 2022 and was reviewed by Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286601: Mac Aarch: Excessive warnings to be ignored for build jdk

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/131/head:pull/131
$ git checkout pull/131

Update a local copy of the PR:
$ git checkout pull/131
$ git pull https://git.openjdk.java.net/jdk18u pull/131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 131

View PR using the GUI difftool:
$ git pr show -t 131

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/131.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2022

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 40f43c6b1ffc88d55dd3223f5d0259ae73cf0356 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk May 13, 2022
@openjdk
Copy link

openjdk bot commented May 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 13, 2022

@adamfarley This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286601: Mac Aarch: Excessive warnings to be ignored for build jdk

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • b9e100c: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • 642208c: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • 2e9dda4: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 3d54587: 8286283: assert(func2 == 0 && func3 == 0) failed: not unary
  • aac6bd5: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 9d0d8ea: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • b5bf90d: 8284992: Fix misleading Vector API doc for LSHR operator
  • 0b9bee7: 8286198: [linux] Fix process-memory information
  • 3b7473c: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2022
@mlbridge
Copy link

mlbridge bot commented May 13, 2022

Webrevs

@adamfarley
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 17, 2022
@openjdk
Copy link

openjdk bot commented May 17, 2022

@adamfarley
Your change (at version 0ec84a0) is now ready to be sponsored by a Committer.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine and I see jdk18u-fix-yes on the bug.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 23, 2022

Going to push as commit c575496.
Since your change was applied there have been 9 commits pushed to the master branch:

  • b9e100c: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • 642208c: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak
  • 2e9dda4: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 3d54587: 8286283: assert(func2 == 0 && func3 == 0) failed: not unary
  • aac6bd5: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • 9d0d8ea: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • b5bf90d: 8284992: Fix misleading Vector API doc for LSHR operator
  • 0b9bee7: 8286198: [linux] Fix process-memory information
  • 3b7473c: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2022
@openjdk openjdk bot closed this May 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@gnu-andrew @adamfarley Pushed as commit c575496.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants