Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8284094: Memory leak in invoker_completeInvokeRequest() #134

Closed

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented May 23, 2022

Hi all,

This pull request contains a backport of commit 1dfa1eae from the openjdk/jdk repository.

The commit being backported was authored by Roman Kennke on 1 Apr 2022 and was reviewed by Chris Plummer and Aleksey Shipilev.

This fixes a memory leak in the JDWP agent. It has baked in trunk for over a month and should now be safe enough to backport to stable releases.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284094: Memory leak in invoker_completeInvokeRequest()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.java.net/jdk18u pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/134.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1dfa1eaea0c8958f4b793c0766e36607cbde5c7f 8284094: Memory leak in invoker_completeInvokeRequest() May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284094: Memory leak in invoker_completeInvokeRequest()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2022
@mlbridge
Copy link

mlbridge bot commented May 23, 2022

Webrevs

@gnu-andrew
Copy link
Member Author

Merged and transferred to #141 as bot won't let me update this branch

@gnu-andrew gnu-andrew closed this May 29, 2022
@RealCLanger
Copy link
Contributor

Merged and transferred to #141 as bot won't let me update this branch

It should work if you had accepted the invitation by the bot. If you missed it, I guess you'd have to notify ops for resend.

@gnu-andrew
Copy link
Member Author

Merged and transferred to #141 as bot won't let me update this branch

It should work if you had accepted the invitation by the bot. If you missed it, I guess you'd have to notify ops for resend.

I accepted it (got caught out by that before) but it still didn't seem to work. Easier just to work with my own tree in future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants