Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8285517: System.getenv() returns unexpected value if environment variable has non ASCII character #139

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented May 26, 2022

Backport JDK-8285517

Backport is not clean.
Because following patch is not integrated on test/jdk/java/lang/ProcessBuilder/Basic.java:
8284161: Implementation of Virtual Threads (Preview)
The modification does not affect logic, just remove following line:
import java.lang.reflect.Field;


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285517: System.getenv() returns unexpected value if environment variable has non ASCII character

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/139/head:pull/139
$ git checkout pull/139

Update a local copy of the PR:
$ git checkout pull/139
$ git pull https://git.openjdk.java.net/jdk18u pull/139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 139

View PR using the GUI difftool:
$ git pr show -t 139

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/139.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2022

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 890771e708277c5f7ea9460ff7bcc7e4cae87eab 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character May 26, 2022
@openjdk
Copy link

openjdk bot commented May 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 26, 2022

@takiguc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285517: System.getenv() returns unexpected value if environment variable has non ASCII character

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2022
@mlbridge
Copy link

mlbridge bot commented May 26, 2022

Webrevs

@takiguc
Copy link
Author

takiguc commented May 31, 2022

jdk18u-fix-yes is verified.

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2022

Going to push as commit 751cadc.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 0928c06: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
  • 3062b46: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups
  • e2acd4f: 8286444: javac errors after JDK-8251329 are not helpful enough to find root cause
  • 87375b4: 8284094: Memory leak in invoker_completeInvokeRequest()
  • 0982707: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
  • d554a32: 8240903: Add test to check that jmod hashes are reproducible
  • b12431d: 8287336: GHA: Workflows break on patch versions
  • ff3712c: 8287119: Add Distrust.java to ProblemList
  • 6d763b0: 8287202: GHA: Add macOS aarch64 to the list of default platforms for workflow_dispatch event

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2022
@openjdk openjdk bot closed this May 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2022
@openjdk
Copy link

openjdk bot commented May 31, 2022

@takiguc Pushed as commit 751cadc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant