This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
8285517: System.getenv() returns unexpected value if environment variable has non ASCII character #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Backport JDK-8285517
Backport is not clean.
Because following patch is not integrated on test/jdk/java/lang/ProcessBuilder/Basic.java:
8284161: Implementation of Virtual Threads (Preview)
The modification does not affect logic, just remove following line:
import java.lang.reflect.Field;
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/139/head:pull/139
$ git checkout pull/139
Update a local copy of the PR:
$ git checkout pull/139
$ git pull https://git.openjdk.java.net/jdk18u pull/139/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 139
View PR using the GUI difftool:
$ git pr show -t 139
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/139.diff