Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8240903: Add test to check that jmod hashes are reproducible #142

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 29, 2022

Hi all,

This pull request contains a backport of JDK-8240903, commit 96952834 from the openjdk/jdk repository.

The commit being backported was authored by Dongbo He on 16 Apr 2022 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8240903: Add test to check that jmod hashes are reproducible

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/142/head:pull/142
$ git checkout pull/142

Update a local copy of the PR:
$ git checkout pull/142
$ git pull https://git.openjdk.java.net/jdk18u pull/142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 142

View PR using the GUI difftool:
$ git pr show -t 142

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/142.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9695283458c273c2a4121f88a2a971ad4f297d5b 8240903: Add test to check that jmod hashes are reproducible May 29, 2022
@openjdk
Copy link

openjdk bot commented May 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 29, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8240903: Add test to check that jmod hashes are reproducible

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 29, 2022
@mlbridge
Copy link

mlbridge bot commented May 29, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

Got fix approval.
/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2022

Going to push as commit d554a32.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2022
@openjdk openjdk bot closed this May 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2022
@openjdk
Copy link

openjdk bot commented May 30, 2022

@RealCLanger Pushed as commit d554a32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant