8287644: [18u] Backport of JDK-8240903 causes test errors #145
Conversation
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@RealCLanger Pushed as commit c08f40e. |
jmod in 18u does not have the option --date which causes a test error. We can leave out its usage in the test.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/145/head:pull/145
$ git checkout pull/145
Update a local copy of the PR:
$ git checkout pull/145
$ git pull https://git.openjdk.java.net/jdk18u pull/145/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 145
View PR using the GUI difftool:
$ git pr show -t 145
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/145.diff