Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8282947: JFR: Dump on shutdown live-locks in some conditions #148

Closed

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Jun 7, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.java.net/jdk18u pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2022

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 8282947: JFR: Dump on shutdown live-locks in some conditions Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@judovana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282947: JFR: Dump on shutdown live-locks in some conditions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@judovana
Copy link
Contributor Author

The debug build failed due to corrupted git pull

@gnu-andrew
Copy link
Member

I think it may make most sense to abandon this and go straight for 17u. 18u is going to be replaced by 19u in September, and this fix won't make what I assume will be the last 18u update in a few weeks time.

@judovana
Copy link
Contributor Author

yup. ok. ty!

@judovana judovana closed this Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants