Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8278525: Additional -Wnonnull errors happen with GCC 11 #152

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 16, 2022

Clean backport for GCC 11 compatibility.

Additional testing:

  • Linux x86_64 fastdebug build with GCC 9

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278525: Additional -Wnonnull errors happen with GCC 11

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk18u pull/152/head:pull/152
$ git checkout pull/152

Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.org/jdk18u pull/152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 152

View PR using the GUI difftool:
$ git pr show -t 152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk18u/pull/152.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6eb6ec05fd4f80e11d0b052b58190bc8b53f4b11 8278525: Additional -Wnonnull errors happen with GCC 11 Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278525: Additional -Wnonnull errors happen with GCC 11

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2022

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

18u is done, no more PRs are accepted.

@shipilev shipilev closed this Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant