Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic #166

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jun 21, 2022

Backport of JDK-8288303. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk18u pull/166/head:pull/166
$ git checkout pull/166

Update a local copy of the PR:
$ git checkout pull/166
$ git pull https://git.openjdk.org/jdk18u pull/166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 166

View PR using the GUI difftool:
$ git pr show -t 166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk18u/pull/166.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8cd87e731bcaff2d7838995c68056742d577ad3b 8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Webrevs

@shipilev
Copy link
Member

I am confused, @TobiHartmann -- are you planning to complete this backport, or?

@TobiHartmann
Copy link
Member Author

@shipilev I opened several PRs for backports to JDK 18.0.2 but was then reminded that it's too late (see https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-June/014674.html) and that there will most likely be no JDK 18.0.3. That's why I closed all of them.

@shipilev
Copy link
Member

@shipilev I opened several PRs for backports to JDK 18.0.2 but was then reminded that it's too late (see https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-June/014674.html) and that there will most likely be no JDK 18.0.3. That's why I closed all of them.

Ah yes, I missed the 18u timeline. All right then!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants