Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8288754: GCC 12 fails to build zReferenceProcessor.cpp #176

Closed
wants to merge 1 commit into from
Closed

8288754: GCC 12 fails to build zReferenceProcessor.cpp #176

wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 22, 2022

Clean backport to improve GCC 12 support.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288754: GCC 12 fails to build zReferenceProcessor.cpp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk18u pull/176/head:pull/176
$ git checkout pull/176

Update a local copy of the PR:
$ git checkout pull/176
$ git pull https://git.openjdk.org/jdk18u pull/176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 176

View PR using the GUI difftool:
$ git pr show -t 176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk18u/pull/176.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 834d92dd72257ab5d8c6759028098ac0867c5752 8288754: GCC 12 fails to build zReferenceProcessor.cpp Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288754: GCC 12 fails to build zReferenceProcessor.cpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

@RealCLanger
Copy link
Contributor

Hm, I think as per https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-June/014674.html, JDK18u is done. I guess it's of no use doing backports to 18 still.

@shipilev
Copy link
Member Author

Hm, I think as per https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-June/014674.html, JDK18u is done. I guess it's of no use doing backports to 18 still.

Right, I missed the 18u timeline. Closing.

@shipilev shipilev closed this Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants