Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free #24

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Feb 12, 2022

Hi all,
This is a test stabilization fix, additional information here.
This pull request contains a backport of commit 7c2c5858 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 12 Dec 2021 and was reviewed by Prasanta Sadhukhan and Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.java.net/jdk18u pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/24.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7c2c58587d4eda5523331eae45e7d897252dc097 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free Feb 12, 2022
@openjdk
Copy link

openjdk bot commented Feb 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 12, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 12, 2022
@mrserb mrserb marked this pull request as ready for review February 13, 2022 00:41
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Feb 17, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

Going to push as commit 525f17f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 09dfa48: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths
  • d2492c4: 8281262: Windows builds in different directories are not fully reproducible
  • 22f6195: Merge
  • 0f2113c: 8280415: Remove EA from JDK 18 version string starting with Initial RC promotion B35 on February 10, 2022
  • 2be2a29: 8281713: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2022
@openjdk openjdk bot closed this Feb 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@mrserb Pushed as commit 525f17f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant