Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled #25

Closed
wants to merge 0 commits into from

Conversation

macarte
Copy link
Contributor

@macarte macarte commented Feb 16, 2022

Backport of 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.java.net/jdk18u pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/25.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2022

👋 Welcome back macarte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4c169495a2c4bfdcbc82e94e9ca1ee0cc050daf9 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@macarte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

⚠️ @macarte a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 22f61959f26ab6b83aeb8b8477834b44ef5c3847
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2022

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant