Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8281262: Windows builds in different directories are not fully reproducible #26

Closed
wants to merge 1 commit into from
Closed

8281262: Windows builds in different directories are not fully reproducible #26

wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Feb 16, 2022 •
edited by openjdk bot

Clean backport.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281262: Windows builds in different directories are not fully reproducible

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.java.net/jdk18u pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/26.diff

@mkartashev @erikj79
8281262: Windows builds in different directories are not fully reprod…
38c8fdb 
…ucible

Co-authored-by: Erik Joelsson <erikj@openjdk.org>
Reviewed-by: erikj, ihse
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2022

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d442328bc2f2f4bc35dd054487a78552e3d9a759 8281262: Windows builds in different directories are not fully reproducible Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 16, 2022 •
edited

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281262: Windows builds in different directories are not fully reproducible

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 22f6195: Merge
  • 0f2113c: 8280415: Remove EA from JDK 18 version string starting with Initial RC promotion B35 on February 10, 2022
  • 2be2a29: 8281713: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 6202ea5: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
  • e1dfd9f: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 9d4b5ed: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
  • 7796859: Merge
  • 01f93dd: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
  • 2531c33: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • f1c7694: 8277795: ldap connection timeout not honoured under contention
  • ... and 77 more: https://git.openjdk.java.net/jdk18u/compare/cbcb39119dd9faf74769a7a6b295e955141cce74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2022
@erikj79
Copy link
Member Author

erikj79 commented Feb 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

Going to push as commit d2492c4.
Since your change was applied there have been 87 commits pushed to the master branch:

  • 22f6195: Merge
  • 0f2113c: 8280415: Remove EA from JDK 18 version string starting with Initial RC promotion B35 on February 10, 2022
  • 2be2a29: 8281713: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 6202ea5: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
  • e1dfd9f: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 9d4b5ed: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
  • 7796859: Merge
  • 01f93dd: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
  • 2531c33: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • f1c7694: 8277795: ldap connection timeout not honoured under contention
  • ... and 77 more: https://git.openjdk.java.net/jdk18u/compare/cbcb39119dd9faf74769a7a6b295e955141cce74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2022
@openjdk openjdk bot closed this Feb 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@erikj79 Pushed as commit d2492c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Feb 16, 2022

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport clean integrated Pull request has been integrated
Milestone
No milestone
2 participants
@erikj79 @mkartashev