Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8279958: Provide configure hints for Alpine/apk package managers #38

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 10, 2022

Clean backport to improve Alpine port.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279958: Provide configure hints for Alpine/apk package managers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/38/head:pull/38
$ git checkout pull/38

Update a local copy of the PR:
$ git checkout pull/38
$ git pull https://git.openjdk.java.net/jdk18u pull/38/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 38

View PR using the GUI difftool:
$ git pr show -t 38

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/38.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a30aa52b77931bcea38213cf3d243d18a37dc858 8279958: Provide configure hints for Alpine/apk package managers Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279958: Provide configure hints for Alpine/apk package managers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.
/integrate

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

Going to push as commit 9089b94.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 92d2de6: 8282225: GHA: Allow one concurrent run per PR only
  • 8fd1a9e: 8283017: GHA: Workflows break with update release versions
  • defa9e8: 8281615: Deadlock caused by jdwp agent
  • 507cbd6: 8282295: SymbolPropertyEntry::set_method_type fails with assert
  • 6bebb34: 8283037: Update jdk18u fix version to 18.0.2
  • afae492: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 16, 2022
@openjdk openjdk bot closed this Mar 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 16, 2022
@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@shipilev Pushed as commit 9089b94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8279958-alpine-hints branch April 6, 2022 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant