Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8281318: Improve jfr/event/allocation tests reliability #42

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 11, 2022

Clean backport to improve JFR tests on x86_32.
Needs JDK-8281638 as the follow-up.

Additional testing:

  • Linux x86_32 fastdebug, affected tests fail without the patch, pass with it

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281318: Improve jfr/event/allocation tests reliability

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.java.net/jdk18u pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/42.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 65831eb294b6f1f5f99988836c00005d41c27fd3 8281318: Improve jfr/event/allocation tests reliability Mar 11, 2022
@openjdk
Copy link

openjdk bot commented Mar 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281318: Improve jfr/event/allocation tests reliability

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c66544f: 8281168: Micro-optimize VarForm.getMemberName for interpreter

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2022

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Apr 6, 2022

Got the push approval.
/integrate

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

Going to push as commit b50949a.
Since your change was applied there have been 46 commits pushed to the master branch:

  • 8904395: 8277893: Arraycopy stress tests
  • 7ebdcf5: 8282194: C1: Missing side effects of dynamic constant linkage
  • 8f3c889: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • a65922b: 8282045: When loop strip mining fails, safepoints are removed from loop anyway
  • 0389833: 8279822: CI: Constant pool entries in error state are not supported
  • 29c7f1c: 8283408: Fix a C2 crash when filling arrays with unsafe
  • c9b8589: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 650fbf8: 8283451: C2: assert(_base == Long) failed: Not a Long
  • 7ca0b98: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
  • 3658f57: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • ... and 36 more: https://git.openjdk.java.net/jdk18u/compare/6b5706a8a06a9fed86780910f3d83838e7fddcb7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@shipilev Pushed as commit b50949a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8281318-jfr-32bit branch April 6, 2022 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant