8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions#43
8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions#43shipilev wants to merge 3 commits intoopenjdk:masterfrom shipilev:JDK-8281638-jfr-test-fixes
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8281318-jfr-32bit
git fetch https://git.openjdk.java.net/jdk18u master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
Got the push approval. /integrate |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Going to push as commit ece6baa. |
Follow-up for JDK-8281318 backport.
Additional testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/43/head:pull/43$ git checkout pull/43Update a local copy of the PR:
$ git checkout pull/43$ git pull https://git.openjdk.java.net/jdk18u pull/43/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 43View PR using the GUI difftool:
$ git pr show -t 43Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/43.diff