Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277893: Arraycopy stress tests #44

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 14, 2022

Clean backport to improve testing.

Additional testing:

  • Linux x86_64 fastdebug passes hotspot_compiler_arraycopy

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/44/head:pull/44
$ git checkout pull/44

Update a local copy of the PR:
$ git checkout pull/44
$ git pull https://git.openjdk.java.net/jdk18u pull/44/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 44

View PR using the GUI difftool:
$ git pr show -t 44

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/44.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 14, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 29bd73638a22d341767a1266723a7d7263e17093 8277893: Arraycopy stress tests Mar 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 14, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277893: Arraycopy stress tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c66544f: 8281168: Micro-optimize VarForm.getMemberName for interpreter

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 14, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 14, 2022

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Apr 6, 2022

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2022

Going to push as commit 8904395.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 7ebdcf5: 8282194: C1: Missing side effects of dynamic constant linkage
  • 8f3c889: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • a65922b: 8282045: When loop strip mining fails, safepoints are removed from loop anyway
  • 0389833: 8279822: CI: Constant pool entries in error state are not supported
  • 29c7f1c: 8283408: Fix a C2 crash when filling arrays with unsafe
  • c9b8589: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 650fbf8: 8283451: C2: assert(_base == Long) failed: Not a Long
  • 7ca0b98: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
  • 3658f57: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • bb950ee: 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers
  • ... and 35 more: https://git.openjdk.java.net/jdk18u/compare/6b5706a8a06a9fed86780910f3d83838e7fddcb7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready rfr labels Apr 6, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2022

@shipilev Pushed as commit 8904395.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8277893-arraycopy-stress-tests branch Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant