Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8282444: Module finder incorrectly assumes default file system path-separator character #48

Closed

Conversation

ChrisHegarty
Copy link
Member

@ChrisHegarty ChrisHegarty commented Mar 15, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282444: Module finder incorrectly assumes default file system path-separator character

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/48/head:pull/48
$ git checkout pull/48

Update a local copy of the PR:
$ git checkout pull/48
$ git pull https://git.openjdk.java.net/jdk18u pull/48/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 48

View PR using the GUI difftool:
$ git pr show -t 48

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/48.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2022

👋 Welcome back chegar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@ChrisHegarty
Copy link
Member Author

/clean

@openjdk openjdk bot changed the title Backport 369291b265e13d625c5f465da9b1854c0d70c435 8282444: Module finder incorrectly assumes default file system path-separator character Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@ChrisHegarty This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@ChrisHegarty This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282444: Module finder incorrectly assumes default file system path-separator character

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@ChrisHegarty
Copy link
Member Author

/issue 8282444

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@ChrisHegarty This issue is referenced in the PR title - it will now be updated.

@mlbridge
Copy link

mlbridge bot commented Mar 15, 2022

Webrevs

@ChrisHegarty
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit 73014a2.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 7bdf94b: 8282583: Update BCEL md to include the copyright notice
  • c66544f: 8281168: Micro-optimize VarForm.getMemberName for interpreter
  • 6b5706a: 8279668: x86: AVX2 versions of vpxor should be asserted

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@ChrisHegarty Pushed as commit 73014a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant