Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8282295: SymbolPropertyEntry::set_method_type fails with assert #49

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Mar 15, 2022

Backport of the fix for JDK-8282295. Patch applied cleanly and was tested with Mach5 tiers 1-2.
Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282295: SymbolPropertyEntry::set_method_type fails with assert

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.java.net/jdk18u pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/49.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2022

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3e4dfc63e75db7e8ccbb21a831d8d86fb7c1ac4e 8282295: SymbolPropertyEntry::set_method_type fails with assert Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282295: SymbolPropertyEntry::set_method_type fails with assert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6bebb34: 8283037: Update jdk18u fix version to 18.0.2
  • afae492: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • 9bd2fc6: 8281093: Violating Attribute-Value Normalization in the XML specification 1.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2022

Webrevs

@hseigel
Copy link
Member Author

hseigel commented Mar 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

Going to push as commit 507cbd6.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 6bebb34: 8283037: Update jdk18u fix version to 18.0.2
  • afae492: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • 9bd2fc6: 8281093: Violating Attribute-Value Normalization in the XML specification 1.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2022
@openjdk openjdk bot closed this Mar 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@hseigel Pushed as commit 507cbd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant