-
Notifications
You must be signed in to change notification settings - Fork 52
8278065: Refactor subclassAudits to use ClassValue #50
Conversation
👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout rkennke-backport-8eb453ba
git fetch https://git.openjdk.java.net/jdk18u master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@rkennke This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit b5ce23b. |
This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072.
The original change has baked for several weeks in jdk19 and applies cleanly.
Testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/50/head:pull/50
$ git checkout pull/50
Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.java.net/jdk18u pull/50/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 50
View PR using the GUI difftool:
$ git pr show -t 50
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/50.diff