Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8283350: (tz) Update Timezone Data to 2022a #52

Closed
wants to merge 1 commit into from

Conversation

satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Mar 25, 2022

Clean backport of JDK-8283350
(tz) Update Timezone Data to 2022a


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.java.net/jdk18u pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/52.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2022

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b05d4ccf8e54635c16bc2c26aa7a8fcc2e3b3dde 8283350: (tz) Update Timezone Data to 2022a Mar 25, 2022
@openjdk
Copy link

openjdk bot commented Mar 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 25, 2022
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not recognized as clean because the files were moved. However, the hunks apply cleanly and the backport looks good to me.

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283350: (tz) Update Timezone Data to 2022a

Reviewed-by: mdoerr, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2022
@satoyoshiki satoyoshiki marked this pull request as ready for review March 28, 2022 22:51
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2022

Webrevs

@satoyoshiki
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@satoyoshiki
Your change (at version cc750b8) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Mar 28, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

Going to push as commit 1ab6f93.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2022
@openjdk openjdk bot closed this Mar 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@naotoj @satoyoshiki Pushed as commit 1ab6f93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
3 participants