Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

Conversation

tschatzl
Copy link

@tschatzl tschatzl commented Mar 25, 2022

Please review this backport of JDK-8283555 G1: Concurrent mark accesses uninitialized BOT of closed archive regions which removes a potential crash.

Applies cleanly.

Testing: gha, jdk19 ci

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.java.net/jdk18u pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/54.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 19f01ab70133d244422684f63f118249178bce4a 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions Mar 25, 2022
@openjdk
Copy link

openjdk bot commented Mar 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 25, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b5ce23b: 8278065: Refactor subclassAudits to use ClassValue
  • 27fbc08: 8280041: Retry loop issues in java.io.ClassCache
  • 76e25e6: 8277072: ObjectStreamClass caches keep ClassLoaders alive

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2022

Webrevs

@tschatzl
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

Going to push as commit 9f39b4b.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 4b0818c: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • 3d289c1: 8281771: Crash in java_lang_invoke_MethodType::print_signature
  • e642530: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info
  • 9327634: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • bc630f8: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15
  • 1ab6f93: 8283350: (tz) Update Timezone Data to 2022a
  • b5ce23b: 8278065: Refactor subclassAudits to use ClassValue
  • 27fbc08: 8280041: Retry loop issues in java.io.ClassCache
  • 76e25e6: 8277072: ObjectStreamClass caches keep ClassLoaders alive

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2022
@openjdk openjdk bot closed this Mar 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@tschatzl Pushed as commit 9f39b4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant