8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes

[TobiHartmann]

Backport of JDK-8282590. Applies cleanly. Approval is pending.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/59/head:pull/59
$ git checkout pull/59

Update a local copy of the PR:
$ git checkout pull/59
$ git pull https://git.openjdk.java.net/jdk18u pull/59/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 59

View PR using the GUI difftool:
$ git pr show -t 59

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/59.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (158dcd27)

[TobiHartmann]

/integrate

[openjdk]

@TobiHartmann Unable to acquire the integration lock; aborting integration. The error has been logged and will be investigated.

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit c9b8589.
Since your change was applied there have been 30 commits pushed to the master branch:

• 650fbf8: 8283451: C2: assert(_base == Long) failed: Not a Long
• 7ca0b98: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
• 3658f57: 8275337: C1: assert(false) failed: live_in set of first block must be empty
• bb950ee: 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers
• 84441e6: 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2
• 33a5dbb: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
• 4ac1e9a: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads
• 1417c0f: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
• 623cc73: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack
• 8956913: 8279219: [REDO] C2 crash when allocating array of size too large
• ... and 20 more: https://git.openjdk.java.net/jdk18u/compare/9327634e982314733f4126a1106be8e452f19f58...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit c9b8589.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.