Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278472: Invalid value set to CANDIDATEFORM structure #6

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jan 20, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278472: Invalid value set to CANDIDATEFORM structure

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jdk18u pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/6.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2022

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2426d58e592c54de64ebe0f06448d239aeced082 8278472: Invalid value set to CANDIDATEFORM structure Jan 20, 2022
@openjdk
Copy link

openjdk bot commented Jan 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278472: Invalid value set to CANDIDATEFORM structure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2022

Webrevs

@aivanov-jdk
Copy link
Member Author

aivanov-jdk commented Jan 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 28, 2022

Going to push as commit cd5a9a9.
Since your change was applied there have been 126 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 28, 2022
@openjdk openjdk bot closed this Jan 28, 2022
@openjdk openjdk bot removed ready rfr labels Jan 28, 2022
@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@aivanov-jdk Pushed as commit cd5a9a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant