Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2 #61

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 29, 2022

Backport of JDK-8272493. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/61/head:pull/61
$ git checkout pull/61

Update a local copy of the PR:
$ git checkout pull/61
$ git pull https://git.openjdk.java.net/jdk18u pull/61/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 61

View PR using the GUI difftool:
$ git pr show -t 61

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/61.diff

…ntrinsic with AVX2

Reviewed-by: redestad, thartmann
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 88f0938c943bfacf748ddb0588a301c2cf7e941e 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2 Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2022

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

Going to push as commit 84441e6.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 33a5dbb: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • 4ac1e9a: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads
  • 1417c0f: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
  • 623cc73: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack
  • 8956913: 8279219: [REDO] C2 crash when allocating array of size too large
  • e580f0e: 8280600: C2: assert(!had_error) failed: bad dominance
  • 662ec01: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/
  • 73c7ddf: 8280901: MethodHandle::linkToNative stub is missing w/ -Xint
  • 2635615: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs
  • 43be343: 8283641: Large value for CompileThresholdScaling causes assert
  • ... and 15 more: https://git.openjdk.java.net/jdk18u/compare/9327634e982314733f4126a1106be8e452f19f58...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2022
@openjdk openjdk bot closed this Apr 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@TobiHartmann Pushed as commit 84441e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants