-
Notifications
You must be signed in to change notification settings - Fork 52
8281181: Do not use CPU Shares to compute active processor count #78
8281181: Do not use CPU Shares to compute active processor count #78
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks,
David
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/label add backport |
@iklam |
I created this PR without following the proper process: https://wiki.openjdk.java.net/display/SKARA/Backports |
Please review this backport of JDK-8281181 to jdk18u. Most changes were cleanly applied, except:
UseContainerCpuShares
andPreferContainerQuotaForCPUCount
) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u.You can compare with the JDK 19 version of the changes here.
Tested with tiers 1-5, including all container test tasks.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/78/head:pull/78
$ git checkout pull/78
Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.java.net/jdk18u pull/78/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 78
View PR using the GUI difftool:
$ git pr show -t 78
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/78.diff