Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk18u Public archive

8281181: Do not use CPU Shares to compute active processor count #79

Conversation

iklam
Copy link
Member

@iklam iklam commented Mar 30, 2022

Please review this backport of JDK-8281181 to jdk18u. Most changes were cleanly applied, except:

  • The changes in related to the deprecation of UseContainerCpuShares and PreferContainerQuotaForCPUCount) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u.

You can compare with the JDK 19 version of the changes here.

Tested with tiers 1-5, including all container test tasks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8281181: Do not use CPU Shares to compute active processor count
  • JDK-8281571: Do not use CPU Shares to compute active processor count (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/79/head:pull/79
$ git checkout pull/79

Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.java.net/jdk18u pull/79/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 79

View PR using the GUI difftool:
$ git pr show -t 79

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/79.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e07fd395bdc314867886a621ec76cf74a5f76b89 8281181: Do not use CPU Shares to compute active processor count Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 30, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks,
David

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281181: Do not use CPU Shares to compute active processor count

Reviewed-by: dholmes, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 9f39b4b: 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions
  • 4b0818c: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • 3d289c1: 8281771: Crash in java_lang_invoke_MethodType::print_signature
  • e642530: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iklam
Copy link
Member Author

iklam commented Mar 31, 2022

Thanks @jerboaa and @dholmes-ora for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

Going to push as commit a541111.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 9f39b4b: 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions
  • 4b0818c: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • 3d289c1: 8281771: Crash in java_lang_invoke_MethodType::print_signature
  • e642530: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 31, 2022
@openjdk openjdk bot closed this Mar 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@iklam Pushed as commit a541111.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants