-
Notifications
You must be signed in to change notification settings - Fork 51
8279822: CI: Constant pool entries in error state are not supported #83
Conversation
Reviewed-by: kvn, thartmann
|
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
Thanks, Dean! |
vnkozlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
|
Thanks, Vladimir! |
|
/integrate |
|
Going to push as commit 0389833.
Your commit was automatically rebased without conflicts. |
|
@TobiHartmann Pushed as commit 0389833. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8279822. Applied cleanly but I had to set the class file version of the test to
V18. Approval is pending.Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/83/head:pull/83$ git checkout pull/83Update a local copy of the PR:
$ git checkout pull/83$ git pull https://git.openjdk.java.net/jdk18u pull/83/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 83View PR using the GUI difftool:
$ git pr show -t 83Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/83.diff