Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8279822: CI: Constant pool entries in error state are not supported #83

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 30, 2022

Backport of JDK-8279822. Applied cleanly but I had to set the class file version of the test to V18. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279822: CI: Constant pool entries in error state are not supported

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jdk18u pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/83.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c5c8c0644d9442846de15422285fffeb91c3e0a1 8279822: CI: Constant pool entries in error state are not supported Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279822: CI: Constant pool entries in error state are not supported

Reviewed-by: dlong, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 29c7f1c: 8283408: Fix a C2 crash when filling arrays with unsafe
  • c9b8589: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 650fbf8: 8283451: C2: assert(_base == Long) failed: Not a Long
  • 7ca0b98: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
  • 3658f57: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • bb950ee: 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers
  • 84441e6: 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2
  • 33a5dbb: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • 4ac1e9a: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads
  • 1417c0f: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
  • ... and 18 more: https://git.openjdk.java.net/jdk18u/compare/9f39b4bf33826ed6524a50dc5e6b0f085b3836ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels Mar 30, 2022
@TobiHartmann
Copy link
Member Author

Thanks, Dean!

Copy link

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 5, 2022
@TobiHartmann
Copy link
Member Author

Thanks, Vladimir!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

Going to push as commit 0389833.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 29c7f1c: 8283408: Fix a C2 crash when filling arrays with unsafe
  • c9b8589: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 650fbf8: 8283451: C2: assert(_base == Long) failed: Not a Long
  • 7ca0b98: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
  • 3658f57: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • bb950ee: 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers
  • 84441e6: 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2
  • 33a5dbb: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • 4ac1e9a: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads
  • 1417c0f: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
  • ... and 18 more: https://git.openjdk.java.net/jdk18u/compare/9f39b4bf33826ed6524a50dc5e6b0f085b3836ff...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@TobiHartmann Pushed as commit 0389833.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
3 participants