-
Notifications
You must be signed in to change notification settings - Fork 52
8282194: C1: Missing side effects of dynamic constant linkage #88
Conversation
Reviewed-by: kvn, thartmann
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@TobiHartmann Since your change was applied there has been 1 commit pushed to the
It was not possible to rebase your changes automatically. Please merge |
/integrate |
Going to push as commit 7ebdcf5. |
@TobiHartmann Pushed as commit 7ebdcf5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8282194. Did not apply cleanly due to changes to surrounding code in
ciStreams.hpp
. Approval is pending.Thanks,
Tobias
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/88/head:pull/88
$ git checkout pull/88
Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.java.net/jdk18u pull/88/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 88
View PR using the GUI difftool:
$ git pr show -t 88
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/88.diff