Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} #9

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 26, 2022

Clean backport to fix the recent regression.

Additional testing:

  • compiler/loopopts/superword/SumRedSqrt_Double.java does not timeout anymore

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.java.net/jdk18u pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/9.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a24f44d17de586c72c8343f8891e72ad8a514597 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} Jan 26, 2022
@openjdk
Copy link

openjdk bot commented Jan 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 26, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.
/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2022

Going to push as commit 5b8f9ff.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 86956ee: 8279445: Update JMH devkit to 1.34
  • cd5a9a9: 8278472: Invalid value set to CANDIDATEFORM structure
  • bb5bc6a: 8274751: Drag And Drop hangs on Windows
  • 76a2b3b: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2022
@openjdk openjdk bot closed this Jan 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@shipilev Pushed as commit 5b8f9ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8280526-math-sqrt branch March 10, 2022 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant