Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer #94

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 7, 2022

Hi all,

This pull request contains a clean backport of JDK-8284389.

The commit being backported was authored by Christoph Langer on 7 Apr 2022 and was reviewed by Aleksey Shipilev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.java.net/jdk18u pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/94.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61fcf2f67ff16bee92a5279e7bcacc79fc8f37ad 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 7, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 10, 2022

Going to push as commit db63984.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 430fe80: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2022
@openjdk openjdk bot closed this Apr 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2022
@openjdk
Copy link

openjdk bot commented Apr 10, 2022

@RealCLanger Pushed as commit db63984.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant