Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8283422: Create a new test for JDK-8254790 #98

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Apr 12, 2022

Hi all,

This pull request contains a backport of commit ad83ec7e from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 31 Mar 2022 and was reviewed by Vladimir Kozlov and Tobias Hartmann.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18u pull/98/head:pull/98
$ git checkout pull/98

Update a local copy of the PR:
$ git checkout pull/98
$ git pull https://git.openjdk.java.net/jdk18u pull/98/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 98

View PR using the GUI difftool:
$ git pr show -t 98

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18u/pull/98.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ad83ec7e281cb3ab7c42e71fab47ea21b93079ea 8283422: Create a new test for JDK-8254790 Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283422: Create a new test for JDK-8254790

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 12, 2022
@mrserb mrserb marked this pull request as ready for review April 24, 2022 22:56
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 96f0e65.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 6b0bcaf: 8284458: CodeHeapState::aggregate() leaks blob_name
  • b2418d8: 8283725: Launching java with "-Xlog:gc*=trace,safepoint*=trace,class*=trace" crashes the JVM
  • 13f4be3: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang
  • b5de192: 8284622: Update versions of some Github Actions used in JDK workflow
  • 8a2234f: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
  • 7afc0e5: 8284866: Add test to JDK-8273056
  • 4c325ba: 8282042: [testbug] FileEncodingTest.java depends on default encoding
  • 2b91865: 8284033: Leak XVisualInfo in getAllConfigs in awt_GraphicsEnv.c
  • 313b033: 8285445: cannot open file "NUL:"
  • 07f4a0f: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • ... and 34 more: https://git.openjdk.java.net/jdk18u/compare/d417c3457996815fcff470d837d051f67e60ddf9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@mrserb Pushed as commit 96f0e65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant