Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Commit

Permalink
8288360: CI: ciInstanceKlass::implementor() is not consistent for wel…
Browse files Browse the repository at this point in the history
…l-known classes

Reviewed-by: thartmann, kvn
  • Loading branch information
Vladimir Ivanov committed Jun 14, 2022
1 parent 5a8e1e4 commit 50f99c3
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/hotspot/share/ci/ciInstanceKlass.cpp
Expand Up @@ -619,8 +619,10 @@ bool ciInstanceKlass::is_leaf_type() {
ciInstanceKlass* ciInstanceKlass::implementor() {
ciInstanceKlass* impl = _implementor;
if (impl == NULL) {
// Go into the VM to fetch the implementor.
{
if (is_shared()) {
impl = this; // assume a well-known interface never has a unique implementor
} else {
// Go into the VM to fetch the implementor.
VM_ENTRY_MARK;
MutexLocker ml(Compile_lock);
Klass* k = get_instanceKlass()->implementor();
Expand All @@ -634,9 +636,7 @@ ciInstanceKlass* ciInstanceKlass::implementor() {
}
}
// Memoize this result.
if (!is_shared()) {
_implementor = impl;
}
_implementor = impl;
}
return impl;
}
Expand Down

5 comments on commit 50f99c3

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 50f99c3 Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 50f99c3 Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-50f99c32 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 50f99c32 from the openjdk/jdk19 repository.

The commit being backported was authored by Vladimir Ivanov on 14 Jun 2022 and was reviewed by Tobias Hartmann and Vladimir Kozlov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-50f99c32:GoeLin-backport-50f99c32
$ git checkout GoeLin-backport-50f99c32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-50f99c32

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 50f99c3 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 50f99c3 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-50f99c32 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 50f99c32 from the openjdk/jdk19 repository.

The commit being backported was authored by Vladimir Ivanov on 14 Jun 2022 and was reviewed by Tobias Hartmann and Vladimir Kozlov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-50f99c32:GoeLin-backport-50f99c32
$ git checkout GoeLin-backport-50f99c32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-50f99c32

Please sign in to comment.