8288850: SegmentAllocator:allocate() can return null some cases

[mcimadamore]

This patch fixes an issue where the arena allocator does not detect an overflow when attempting to allocate a new slice.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288850: SegmentAllocator:allocate() can return null some cases

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/133/head:pull/133
$ git checkout pull/133

Update a local copy of the PR:
$ git checkout pull/133
$ git pull https://git.openjdk.org/jdk19 pull/133/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 133

View PR using the GUI difftool:
$ git pr show -t 133

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/133.diff

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5418e4e6)

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288850: SegmentAllocator:allocate() can return null some cases

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
• 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit 2baf526.
Since your change was applied there have been 4 commits pushed to the master branch:

• 3164c98: 8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM
• c3806b9: 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions
• 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
• 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit 2baf526.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.