Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19 Public archive

8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all #137

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 12, 2022

A trivial fix to ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/137/head:pull/137
$ git checkout pull/137

Update a local copy of the PR:
$ git checkout pull/137
$ git pull https://git.openjdk.org/jdk19 pull/137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 137

View PR using the GUI difftool:
$ git pr show -t 137

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/137.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review July 12, 2022 21:16
@dcubed-ojdk
Copy link
Member Author

@naotoj - Thanks for the fast code review.

@dcubed-ojdk
Copy link
Member Author

/integrate auto

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fff7f35: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode
  • 128c6c6: 8290095: java/nio/channels/FileChannel/largeMemory/LargeGatheringWrite.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/integrate auto

@openjdk openjdk bot added the auto label Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

Going to push as commit ce36f6e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • fff7f35: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode
  • 128c6c6: 8290095: java/nio/channels/FileChannel/largeMemory/LargeGatheringWrite.java timed out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2022
@openjdk openjdk bot closed this Jul 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@openjdk[bot] Pushed as commit ce36f6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@openjdk[bot] The command integrate can only be used in open pull requests.

@mlbridge
Copy link

mlbridge bot commented Jul 12, 2022

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8290203 branch July 13, 2022 01:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants